skip timeout ping tests if test targets are unreachable#122987
Merged
wfurt merged 1 commit intodotnet:mainfrom Jan 9, 2026
Merged
skip timeout ping tests if test targets are unreachable#122987wfurt merged 1 commit intodotnet:mainfrom
wfurt merged 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #115358 by enhancing the timeout ping tests to gracefully skip execution when test targets are unreachable. The main change is adding a check for DestinationNetworkUnreachable status and throwing a SkipTestException to prevent false test failures.
- Adds runtime check to skip tests when all unreachable test targets return
DestinationNetworkUnreachable - Converts three timeout test methods from
[Fact]to[ConditionalFact]to support dynamic test skipping
This was referenced Jan 7, 2026
Open
steveisok
pushed a commit
to steveisok/runtime
that referenced
this pull request
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #115358